Hi, I tried this with our docs that use ipywidgets progress bars via tqdm. The text around the progress bar still doesn't honor the color preference from the furo theme when rendered with myst-nb. I just modified the CSS with the one from this PR. Am I missing anything, or is there an issue?

This PR is just for preventing MyST-nb from messing up a theme’s table CSS. I re-titled #618 to be more clear.

For ipywidgets to work properly, the theme needs to integrate with them by setting --jp-widgets-color and so on or by hacking it with a light background.

E.g. sphinx-book-theme currently does

html[data-theme="dark"] .bd-content div.cell_output .text_html:not(:has(table.dataframe)),
html[data-theme="dark"] .bd-content div.cell_output .widget-subarea,
html[data-theme="dark"] .bd-content div.cell_output img {
  background-color: var(--some-light-color);
}

It would have to remove the second selector (.widget-subarea) and define all the --jp-widgets-* variables to really support ipywidgets.

But this PR is a very necessary pre-condition for anything to be able to work. MyST just injecting this CSS is really bad and needs to be fixed!

@bsipocz is there any recorded reason why that CSS exists?

If yes, we need to fix this in another way.

If not, we should really remove this without replacement, just setting styles for div.cell_output table is very bad manners for an extension.

@bsipocz OK, so no reason not to merge this now, right?

@bsipocz OK, so no reason not to merge this now, right?

no reason just the lack of time. don't have JB1 using repos any more, so it would help review to have before/after screenshot for these types of changes.

I totally get that! We all have limited time and it can be hard.

Regarding previewing changes

The docs/readthedocs.org:myst-nb CI job builds the docs with the PR changes, so you can see at least how the changes affect the sphinx book theme, in this case like here: https://myst-nb--693.org.readthedocs.build/en/693/render/interactive.html

Regarding the visual changes this PR caused

The effect is that the padding is reduced, but as said, it makes no sense that some of the table styling

1. lives in myst-nb and affects all tables, while the rest
2. lives in the theme and only affects very specifically table.dataframe living inside of

if you want e.g. increase the padding of the pydata theme, that should happen in sphinx-book-theme and not in this extension, and should use similarly specific CSS selectors to affect the same tables, not all tables.

the other visual changes caused by this PR is simply that this extension’s dark mode support is now better.

it now supports themes that set data-theme on body instead of html (like the popular Furo), and themes that don’t have a color toggle, but signal that they support the supports-color-scheme media query using <meta name="color-scheme">